Skip to content

Comments

[SPARK-21611][SQL]Error class name for log in several classes.#18816

Closed
zuotingbing wants to merge 2 commits intoapache:masterfrom
zuotingbing:SPARK-21611
Closed

[SPARK-21611][SQL]Error class name for log in several classes.#18816
zuotingbing wants to merge 2 commits intoapache:masterfrom
zuotingbing:SPARK-21611

Conversation

@zuotingbing
Copy link

What changes were proposed in this pull request?

Error class name for log in several classes. such as:
2017-08-02 16:43:37,695 INFO CompositeService: Operation log root directory is created: /tmp/mr/operation_logs
Operation log root directory is created ... is in SessionManager.java actually.

How was this patch tested?

manual tests

private val sessionState = SessionState.get().asInstanceOf[CliSessionState]

private val LOG = LogFactory.getLog("CliDriver")
private val LOG = LogFactory.getLog("SparkSQLCLIDriver")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can say classOf[SparkSQLCLIDriver] too but this works.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fix it. Thanks

@SparkQA
Copy link

SparkQA commented Aug 2, 2017

Test build #3868 has finished for PR 18816 at commit f1237c5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 3, 2017

Test build #3876 has finished for PR 18816 at commit 0b1b898.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Aug 3, 2017

Merged to master

@asfgit asfgit closed this in 3221470 Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants