[SPARK-21605][BUILD] Let IntelliJ IDEA correctly detect Language level and Target byte code version#18808
Closed
baibaichen wants to merge 1 commit intoapache:masterfrom
baibaichen:feature/idea-fix
Closed
[SPARK-21605][BUILD] Let IntelliJ IDEA correctly detect Language level and Target byte code version#18808baibaichen wants to merge 1 commit intoapache:masterfrom baibaichen:feature/idea-fix
baibaichen wants to merge 1 commit intoapache:masterfrom
baibaichen:feature/idea-fix
Conversation
Contributor
Author
|
cc @gslowikowski , @srowen |
Member
|
This may need a JIRA to track it. |
baibaichen
changed the title
Contributor
Author
Contributor
|
I removed too much in #18750. Eclipse uses these two configuration parameters of |
Member
|
Jenkins, test this please |
srowen
approved these changes
Aug 2, 2017
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looks good. It's not really a hot-fix though. Is encoding needed?
baibaichen
changed the title
…l and Target byte code version With SPARK-21592, removing source and target properties from maven-compiler-plugin lets IntelliJ IDEA use default Language level and Target byte code version which are 1.4. This change adds source, target and encoding properties back to fix this issues. As I test, it doesn't increase compile time.
Contributor
Author
|
Contributor
Author
|
Jenkins, test this please |
srowen
approved these changes
Aug 2, 2017
Member
|
We may need a committer to trigger the jenkins. |
|
Test build #3870 has finished for PR 18808 at commit
|
|
Test build #3871 has finished for PR 18808 at commit
|
|
Test build #3873 has started for PR 18808 at commit |
Member
|
I hit the same issue! Thanks for fixing it! |
|
Test build #3874 has finished for PR 18808 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With SPARK-21592, removing source and target properties from maven-compiler-plugin lets IntelliJ IDEA use default Language level and Target byte code version which are 1.4.
This change adds source, target and encoding properties back to fix this issue. As I test, it doesn't increase compile time.