Skip to content

Fix Java SimpleApp spark application #18795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christiam wants to merge 2 commits into from
Closed

Fix Java SimpleApp spark application #18795

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af272d
Fix Java SimpleApp spark application
christiam Aug 1, 2017
7471781
Additional fixes for Java
christiam Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,12 +297,13 @@ We'll create a very simple Spark application, `SimpleApp.java`:
{% highlight java %}
/* SimpleApp.java */
import org.apache.spark.sql.SparkSession;
import org.apache.spark.sql.Dataset;

public class SimpleApp {
public static void main(String[] args) {
String logFile = "YOUR_SPARK_HOME/README.md"; // Should be some file on your system
SparkSession spark = SparkSession.builder().appName("Simple Application").getOrCreate();
Dataset<String> logData = spark.read.textFile(logFile).cache();
Dataset<String> logData = spark.read().textFile(logFile).cache();

long numAs = logData.filter(s -> s.contains("a")).count();
long numBs = logData.filter(s -> s.contains("b")).count();
Expand Down Expand Up @@ -330,6 +331,10 @@ Note that Spark artifacts are tagged with a Scala version.
<name>Simple Project</name>
<packaging>jar</packaging>
<version>1.0</version>
<properties>

@srowen srowen Aug 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not giving the complete Maven config here, and Java 8 is required, so that's one of many pieces of config I think we assume the user will fill in. (Anyway, this is probably better specified by configuring the compiler plugin directly)?

But I agree with the two changes above. Any other bits of Java example with a similar problem?

@christiam christiam Aug 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other bits of Java example with a similar problem?

Not that I'm currently aware of.

@srowen srowen Aug 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two other instances in structured-streaming-programming-guide.md around line 1044.
If you can address those and remove this stanza, I'll merge

@christiam christiam Aug 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can address those and remove this stanza, I'll merge.

This is done.

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
</properties>
<dependencies>
<dependency> <!-- Spark dependency -->
<groupId>org.apache.spark</groupId>
Expand Down