[SPARK-21306][ML] For branch 2.0, OneVsRest should support setWeightCol #18764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facaiy
referenced
this pull request
Jul 28, 2017
## What changes were proposed in this pull request? add `setWeightCol` method for OneVsRest. `weightCol` is ignored if classifier doesn't inherit HasWeightCol trait. ## How was this patch tested? + [x] add an unit test. Author: Yan Facai (颜发才) <[email protected]> Closes #18554 from facaiy/BUG/oneVsRest_missing_weightCol. (cherry picked from commit a5a3189) Signed-off-by: Yanbo Liang <[email protected]>
## What changes were proposed in this pull request? add `setWeightCol` method for OneVsRest. `weightCol` is ignored if classifier doesn't inherit HasWeightCol trait. ## How was this patch tested? + [x] add an unit test. Author: Yan Facai (颜发才) <[email protected]> Closes apache#18554 from facaiy/BUG/oneVsRest_missing_weightCol. (cherry picked from commit a5a3189) Signed-off-by: Yanbo Liang <[email protected]>
facaiy
force-pushed
the
BUG/branch-2.0_OneVsRest_support_setWeightCol
branch
from
0c60c28 to
e695889
Compare
Contributor
|
Jenkins, test this please. |
Contributor
|
@srowen Could you help to trigger this job? Thanks. |
Contributor
Author
|
Thanks, @yanboliang . Could you give a hand, @srowen ? |
|
Test build #3865 has finished for PR 18764 at commit
|
Contributor
Author
|
Jenkins, test this please. |
Contributor
Author
|
Test failures in pyspark.ml.tests with python2.6, but I don't have the environment. |
Contributor
|
@facaiy No worries, I will take a look. |
Contributor
Author
|
@yanboliang Thanks, yanbo. I am not familar with python 2.6, which is too outdated. |
yanboliang
reviewed
Aug 5, 2017
python/pyspark/ml/classification.py
Outdated
| weightCol = self.getWeightCol() | ||
| else: | ||
| warnings.warn("weightCol is ignored, " | ||
| "as it is not supported by {} now.".format( |
Contributor
Author
There was a problem hiding this comment.
Thank you very much for help, @yanboliang !
Contributor
Author
|
@SparkQA Take a test, please. |
Contributor
|
ok to test |
Contributor
|
Jenkins, test this please. |
Member
|
ok to test |
|
Test build #80344 has finished for PR 18764 at commit
|
Contributor
Author
|
Thanks, @yanboliang @gatorsmile |
Contributor
|
Merged into branch-2.0. Thanks @facaiy @gatorsmile |
asfgit
pushed a commit
that referenced
this pull request
Aug 8, 2017
The PR is related to #18554, and is modified for branch 2.0. ## What changes were proposed in this pull request? add `setWeightCol` method for OneVsRest. `weightCol` is ignored if classifier doesn't inherit HasWeightCol trait. ## How was this patch tested? + [x] add an unit test. Author: Yan Facai (颜发才) <[email protected]> Closes #18764 from facaiy/BUG/branch-2.0_OneVsRest_support_setWeightCol.
Contributor
|
It seems github can't close this PR automatically. @facaiy Please feel free to close it manually. Thanks. |
Contributor
Author
|
Sure, thanks, @yanboliang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is related to #18554, and is modified for branch 2.0.
What changes were proposed in this pull request?
add
setWeightColmethod for OneVsRest.weightColis ignored if classifier doesn't inherit HasWeightCol trait.How was this patch tested?