Skip to content

[SPARK-21530] Update description of spark.shuffle.maxChunksBeingTransferred. #18735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jinxing64 wants to merge 3 commits into from
Closed

[SPARK-21530] Update description of spark.shuffle.maxChunksBeingTransferred. #18735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad710dd
Update description of spark.shuffle.maxChunksBeingTransferred
Jul 26, 2017
14f857e
refine according to tgravescs's comments
Jul 26, 2017
7db7cc7
refine description
Jul 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ public Properties cryptoConf() {

/**
* The max number of chunks allowed to being transferred at the same time on shuffle service.
* Note that new coming connections will be closed when the max number is hit. Client should

@tgravescs tgravescs Jul 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as below

* have retry mechanism, otherwise it will end up with fetch failure.
*/
public long maxChunksBeingTransferred() {
return conf.getLong("spark.shuffle.maxChunksBeingTransferred", Long.MAX_VALUE);
Expand Down
2 changes: 2 additions & 0 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,8 @@ Apart from these, the following properties are also available, and may be useful
<td>Long.MAX_VALUE</td>
<td>
The max number of chunks allowed to being transferred at the same time on shuffle service.
Note that new coming connections will be closed when the max number is hit. Client should

@tgravescs tgravescs Jul 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to say: allowed to be transferred

new coming should be new incoming.

Perhaps we could clarify a bit because Spark has a built in retry mechanism. Could we rephrase to something like: The client will retry according to the shuffle retry configs (see spark.shuffle.io.maxRetries and spark.shuffle.io.retryWait), if those limits are reached the task will fail with fetch failure.

@jinxing64 jinxing64 Jul 26, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is much better.

have retry mechanism, otherwise it will end up with fetch failure.
</td>
</tr>
<tr>
Expand Down