Skip to content

[SPARK-21517][CORE] Avoid copying memory when transfer chunks remotely #18723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caneGuy wants to merge 2 commits into from
Closed

[SPARK-21517][CORE] Avoid copying memory when transfer chunks remotely #18723

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab82c3e
[SPARK][CORE] Avoid copying memory when transfer chunks remotely
caneMi Jul 24, 2017
4c576a4
Use chunks.length instead
caneMi Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private[spark] class ChunkedByteBuffer(var chunks: Array[ByteBuffer]) {
* Wrap this buffer to view it as a Netty ByteBuf.
*/
def toNetty: ByteBuf = {
Unpooled.wrappedBuffer(getChunks(): _*)
Unpooled.wrappedBuffer(chunks.length + 1, getChunks(): _*)
Copy link
Member

@kiszk kiszk Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why chunks.length+1 instead of chunks.length?

Copy link
Contributor Author

@caneGuy caneGuy Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the value to chunks.length

}

/**
Expand Down