[SPARK-21463] Allow userSpecifiedSchema to override partition inference performed by MetadataLogFileIndex#18676
Closed
brkyvz wants to merge 6 commits intoapache:masterfrom
Closed
[SPARK-21463] Allow userSpecifiedSchema to override partition inference performed by MetadataLogFileIndex#18676brkyvz wants to merge 6 commits intoapache:masterfrom
brkyvz wants to merge 6 commits intoapache:masterfrom
Conversation
…y MetadataLogFileIndex
Contributor
Author
|
One thing that worries me is the fact that we're paying the price of inferring partitions and reading all files from the log twice. I tried re-using the cc @zsxwing |
|
Test build #79723 has finished for PR 18676 at commit
|
|
Test build #79724 has finished for PR 18676 at commit
|
|
Test build #79721 has finished for PR 18676 at commit
|
|
Test build #79730 has finished for PR 18676 at commit
|
Member
|
LGTM |
Contributor
Author
|
Thanks! Merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When using the MetadataLogFileIndex to read back a table, we don't respect the user provided schema as the proper column types. This can lead to issues when trying to read strings that look like dates that get truncated to DateType, or longs being truncated to IntegerType, just because a long value doesn't exist.
How was this patch tested?
Unit tests and manual tests