Skip to content

[SPARK-21343] Refine the document for spark.reducer.maxReqSizeShuffleToMem. #18566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jinxing64 wants to merge 3 commits into from
Closed

[SPARK-21343] Refine the document for spark.reducer.maxReqSizeShuffleToMem. #18566

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fd9403
Refine the document for spark.reducer.maxReqSizeShuffleToMem.
Jul 7, 2017
1a042dd
Update configuration.md.
Jul 8, 2017
45ddd75
refine comments
Jul 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/scala/org/apache/spark/internal/config/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,10 @@ package object config {

private[spark] val REDUCER_MAX_REQ_SIZE_SHUFFLE_TO_MEM =
ConfigBuilder("spark.reducer.maxReqSizeShuffleToMem")
.internal()
.doc("The blocks of a shuffle request will be fetched to disk when size of the request is " +
"above this threshold. This is to avoid a giant request takes too much memory.")
"above this threshold. This is to avoid a giant request takes too much memory. Note that" +
" it's necessary to have the support of shuffle service(at least Spark-2.2) when enable " +
Copy link
Contributor

@cloud-fan cloud-fan Jul 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to implement this feature without shuffle service?

"this config.")
.bytesConf(ByteUnit.BYTE)
.createWithDefault(Long.MaxValue)

Expand Down
9 changes: 9 additions & 0 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,15 @@ Apart from these, the following properties are also available, and may be useful
By allowing it to limit the number of fetch requests, this scenario can be mitigated.
</td>
</tr>
<tr>
<td><code>spark.reducer.maxReqSizeShuffleToMem</code></td>
<td>200m</td>
Copy link
Contributor

@cloud-fan cloud-fan Jul 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong

<td>
The blocks of a shuffle request will be fetched to disk when size of the request is above
this threshold. This is to avoid a giant request takes too much memory. Note that it's
necessary to have the support of shuffle service(at least Spark-2.2) when enable this config.
Copy link
Contributor

@cloud-fan cloud-fan Jul 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also mention how to enable this config, e.g. set it to 200m

</td>
</tr>
<tr>
<td><code>spark.shuffle.compress</code></td>
<td>true</td>
Expand Down