Skip to content

[Minor][SS][DOCS] Minor doc change for kafka integration#18550

Closed
viirya wants to merge 1 commit intoapache:masterfrom
viirya:minor-ss-kafka-doc
Closed

[Minor][SS][DOCS] Minor doc change for kafka integration#18550
viirya wants to merge 1 commit intoapache:masterfrom
viirya:minor-ss-kafka-doc

Conversation

@viirya
Copy link
Copy Markdown
Member

@viirya viirya commented Jul 6, 2017

What changes were proposed in this pull request?

Minor change to kafka integration document for structured streaming.

How was this patch tested?

N/A, doc change only.

@viirya
Copy link
Copy Markdown
Member Author

viirya commented Jul 6, 2017

cc @ithjz This may help for your question.

@viirya
Copy link
Copy Markdown
Member Author

viirya commented Jul 6, 2017

cc @tdas

@viirya viirya changed the title [Minor][SS] Minor doc change for kafka integration [Minor][SS][DOCS] Minor doc change for kafka integration Jul 6, 2017
@SparkQA
Copy link
Copy Markdown

SparkQA commented Jul 6, 2017

Test build #79270 has finished for PR 18550 at commit 95937e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.


./bin/spark-submit --packages org.apache.spark:spark-sql-kafka-0-10_{{site.SCALA_BINARY_VERSION}}:{{site.SPARK_VERSION_SHORT}} ...

For experimenting on `spark-shell`, you can also use `--packages` to add `spark-sql-kafka-0-10_{{site.SCALA_BINARY_VERSION}}` and its dependencies directly,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @viirya
For spark-shell, is you need to use better than you can also use because there is no other way?

Copy link
Copy Markdown
Member Author

@viirya viirya Jul 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. the you can also use is relative to spark-submit. Above this, spark-submit uses --packages to add library, so here it says you can also use this option to add library.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. In the Linking section, there is a warning need to add. So, I think we had better to be more clear here.

For experimenting on `spark-shell`, you need to add this above library and its dependencies too when invoking `spark-shell`. Also see the [Deploying](#deploying) subsection below.

For the Deploy section, it looks like that as you said.

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

@viirya
Copy link
Copy Markdown
Member Author

viirya commented Jul 20, 2017

ping @tdas Please take a look for this simple doc change. Thanks.

@srowen
Copy link
Copy Markdown
Member

srowen commented Jul 21, 2017

Merged to master

@asfgit asfgit closed this in c57dfae Jul 21, 2017
@viirya viirya deleted the minor-ss-kafka-doc branch December 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants