[SPARK-21101][SQL] Catch IllegalStateException when CREATE TEMPORARY FUNCTION

[wangyum]

What changes were proposed in this pull request?

It must override public StructObjectInspector initialize(ObjectInspector[] argOIs) when create a UDTF.

If you override public StructObjectInspector initialize(StructObjectInspector argOIs), IllegalStateException will throw. per: HIVE-12377.

This PR catch IllegalStateException and point user to override public StructObjectInspector initialize(ObjectInspector[] argOIs).

How was this patch tested?

unit tests

Source code and binary jar: SPARK-21101.zip
These two source code copy from : https://github.com/apache/hive/blob/release-2.0.0/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java

[SparkQA]

Test build #79152 has finished for PR 18527 at commit a3bd52b.

• This patch fails PySpark pip packaging tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

Retest this please

[dongjoon-hyun]

Hi, @wangyum .
Can we move this after line 112, case NonFatal(e) =>?
IMO, these 8 lines are mostly duplication logic of line 113~116. The only difference is error message.
I guess we can append the new error message more simply.

[SparkQA]

Test build #79160 has finished for PR 18527 at commit a3bd52b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

Can you add a test? I think it's okay to add a source file for UDTF in sql/hive/src/test/java/org/apache/spark/sql/hive/execution or sql/hive/src/test/resources and add the test.

[maropu]

IMO it'd be better to fix code so we could call both interfaces (deprecated and non-deprecated initialize) instead of throwing the exception. cc: @hvanhovell

[SparkQA]

Test build #79173 has finished for PR 18527 at commit 188ed85.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #79199 has finished for PR 18527 at commit 479fd44.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[wangyum]

Retest this please

[SparkQA]

Test build #79204 has finished for PR 18527 at commit 479fd44.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

ping @wangyum This sounds a reasonable fix. Could you resolve the conflicts?

[SparkQA]

Test build #83007 has finished for PR 18527 at commit 47071b5.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[wangyum]

Retest this please

[SparkQA]

Test build #83009 has finished for PR 18527 at commit 47071b5.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

          val noHandlerMsg = s"No handler for UDF/UDAF/UDTF '${clazz.getCanonicalName}': $e"
          val errorMsg =
            if (classOf[GenericUDTF].isAssignableFrom(clazz)) {
              s"$noHandlerMsg\nPlease make sure your function overrides " +
                "`public StructObjectInspector initialize(ObjectInspector[] args)`."
            } else {
              noHandlerMsg
            }
          val analysisException = new AnalysisException(errorMsg)

[SparkQA]

Test build #83021 has finished for PR 18527 at commit f5e895b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

LGTM

[gatorsmile]

Thanks! Merged to master.