[SPARK-20889][SparkR] Grouped documentation for MISC column methods#18448
[SPARK-20889][SparkR] Grouped documentation for MISC column methods#18448actuaryzhang wants to merge 4 commits intoapache:masterfrom
Conversation
|
@felixcheung @HyukjinKwon |
|
Test build #78770 has finished for PR 18448 at commit
|
|
jenkins, test this please |
|
Test build #78814 has finished for PR 18448 at commit
|
|
|
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
LGTM - few minor comments
| #' Miscellaneous functions defined for \code{Column}. | ||
| #' | ||
| #' @param x Column to compute on. In \code{sha2}, it is one of 224, 256, 384, or 512. | ||
| #' @param y Column to compute on. |
There was a problem hiding this comment.
probably not only in this PR ... since y always go first, should we flip this order I think? list y first?
There was a problem hiding this comment.
I think roxygen automatically chooses the order of the arguments based on the order they appear in the file, and ignores the order we specify. So even if I move y before x here, in the generated doc, x will still appear before y. Indeed, as you can see from the screenshot, ... appears before y.
| #' | ||
| #' @param x Column to compute on. In \code{sha2}, it is one of 224, 256, 384, or 512. | ||
| #' @param y Column to compute on. | ||
| #' @param ... additional columns. |
There was a problem hiding this comment.
nit: capital Columns to indicate type
|
Test build #78854 has finished for PR 18448 at commit
|
|
Test build #78865 has finished for PR 18448 at commit
|
|
Test build #78916 has finished for PR 18448 at commit
|
|
merged to master. |
3 participants
What changes were proposed in this pull request?
Grouped documentation for column misc methods.