Skip to content

[SPARK-21176] [Web UI] Limit number of selector threads for admin ui proxy servlets to 8 #18437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IngoSchuster wants to merge 4 commits into from
Closed

[SPARK-21176] [Web UI] Limit number of selector threads for admin ui proxy servlets to 8 #18437

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d7d4f1
SPARK-21176: Limit number of selector threads for ProxyServlet to 8
IngoSchuster Jun 23, 2017
7cc808b
Update JettyUtils.scala
IngoSchuster Jun 28, 2017
1e17a20
Update JettyUtils.scala
IngoSchuster Jun 29, 2017
c6198d2
Update JettyUtils.scala
IngoSchuster Jun 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/main/scala/org/apache/spark/ui/JettyUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import scala.language.implicitConversions
import scala.xml.Node

import org.eclipse.jetty.client.api.Response
import org.eclipse.jetty.client.HttpClient
import org.eclipse.jetty.client.http.HttpClientTransportOverHTTP
import org.eclipse.jetty.proxy.ProxyServlet
import org.eclipse.jetty.server._
import org.eclipse.jetty.server.handler._
Expand Down Expand Up @@ -208,6 +210,13 @@ private[spark] object JettyUtils extends Logging {
rewrittenURI.toString()
}

override def newHttpClient(): HttpClient = {
// Use the Jetty logic to calculate the number of selector threads (#CPUs/2),
// but limit it to 8 max.

@jiangxb1987 jiangxb1987 Jun 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also explain why we are limiting the number of selectors in the comment above?

val numSelectors = math.max(1,math.min(8,Runtime.getRuntime().availableProcessors()/2))

@srowen srowen Jun 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail style tests @IngoSchuster -- we need spaces around operators, after commas, etc.

@IngoSchuster IngoSchuster Jun 28, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aargh - what an unnecessary failure, sorry about that :(.
I've corrected the line in question, the Scala style tests do pass now.

return new HttpClient(new HttpClientTransportOverHTTP(numSelectors), null)
}

override def filterServerResponseHeader(
clientRequest: HttpServletRequest,
serverResponse: Response,
Expand Down