[MINOR][DOCS] Docs in DataFrameNaFunctions.scala use wrong method #18398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changes were proposed in this pull request? * The methods written in this file are methods of `df.na` not `df`. * Filled in some missing parentheses ## How was this patch tested? N/A
srowen
approved these changes
Jun 23, 2017
|
Test build #3807 has finished for PR 18398 at commit
|
|
Test build #3809 has finished for PR 18398 at commit
|
Member
|
Thanks! Merging to master/2.2/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2017
## What changes were proposed in this pull request? * Following the first few examples in this file, the remaining methods should also be methods of `df.na` not `df`. * Filled in some missing parentheses ## How was this patch tested? N/A Author: Ong Ming Yang <[email protected]> Closes #18398 from ongmingyang/master. (cherry picked from commit 4cc6295) Signed-off-by: Xiao Li <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2017
## What changes were proposed in this pull request? * Following the first few examples in this file, the remaining methods should also be methods of `df.na` not `df`. * Filled in some missing parentheses ## How was this patch tested? N/A Author: Ong Ming Yang <[email protected]> Closes #18398 from ongmingyang/master. (cherry picked from commit 4cc6295) Signed-off-by: Xiao Li <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 29, 2017
## What changes were proposed in this pull request? * Following the first few examples in this file, the remaining methods should also be methods of `df.na` not `df`. * Filled in some missing parentheses ## How was this patch tested? N/A Author: Ong Ming Yang <[email protected]> Closes apache#18398 from ongmingyang/master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
df.nanotdf.How was this patch tested?
N/A