Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Jun 22, 2017

Monitoring for standalone cluster mode is not implemented (see SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client mode;
cluster mode applications will be correctly launched and will work, but monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".

…uster mode.

Monitoring for standalone cluster mode is not implemented (see SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client mode;
cluster mode applications will be correctly launched and will work, but monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".
@SparkQA
Copy link

SparkQA commented Jun 23, 2017

Test build #78485 has finished for PR 18397 at commit b7da07d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jun 23, 2017

Can't find any failures in the output...

@vanzin
Copy link
Contributor Author

vanzin commented Jun 23, 2017

retest this please

@vanzin
Copy link
Contributor Author

vanzin commented Jun 23, 2017

test this please

@SparkQA
Copy link

SparkQA commented Jun 23, 2017

Test build #78489 has finished for PR 18397 at commit b7da07d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 23, 2017

Test build #78490 has finished for PR 18397 at commit b7da07d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @cloud-fan

@cloud-fan
Copy link
Contributor

LGTM, merging to master!

@asfgit asfgit closed this in bfd73a7 Jun 24, 2017
asfgit pushed a commit that referenced this pull request Jun 24, 2017
…uster mode.

Monitoring for standalone cluster mode is not implemented (see SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client mode;
cluster mode applications will be correctly launched and will work, but monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".

Author: Marcelo Vanzin <[email protected]>

Closes #18397 from vanzin/SPARK-21159.

(cherry picked from commit bfd73a7)
Signed-off-by: Wenchen Fan <[email protected]>
@cloud-fan
Copy link
Contributor

backported to 2.2/2.1

asfgit pushed a commit that referenced this pull request Jun 24, 2017
…uster mode.

Monitoring for standalone cluster mode is not implemented (see SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client mode;
cluster mode applications will be correctly launched and will work, but monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".

Author: Marcelo Vanzin <[email protected]>

Closes #18397 from vanzin/SPARK-21159.

(cherry picked from commit bfd73a7)
Signed-off-by: Wenchen Fan <[email protected]>
robert3005 pushed a commit to palantir/spark that referenced this pull request Jun 29, 2017
…uster mode.

Monitoring for standalone cluster mode is not implemented (see SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client mode;
cluster mode applications will be correctly launched and will work, but monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".

Author: Marcelo Vanzin <[email protected]>

Closes apache#18397 from vanzin/SPARK-21159.
@vanzin vanzin deleted the SPARK-21159 branch July 18, 2017 20:37
jzhuge pushed a commit to jzhuge/spark that referenced this pull request Aug 20, 2018
…uster mode.

Monitoring for standalone cluster mode is not implemented (see SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client mode;
cluster mode applications will be correctly launched and will work, but monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".

Author: Marcelo Vanzin <[email protected]>

Closes apache#18397 from vanzin/SPARK-21159.

(cherry picked from commit bfd73a7)
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants