Skip to content

[SPARK-20338][CORE]Spaces in spark.eventLog.dir are not correctly handled#18285

Closed
zuotingbing wants to merge 2 commits intoapache:masterfrom
zuotingbing:spark-resolveURI
Closed

[SPARK-20338][CORE]Spaces in spark.eventLog.dir are not correctly handled#18285
zuotingbing wants to merge 2 commits intoapache:masterfrom
zuotingbing:spark-resolveURI

Conversation

@zuotingbing
Copy link
Copy Markdown

@zuotingbing zuotingbing commented Jun 13, 2017

What changes were proposed in this pull request?

“spark.eventLog.dir” supports with space characters.

  1. Update EventLoggingListenerSuite like testDir = Utils.createTempDir(namePrefix = s"history log")
  2. Fix EventLoggingListenerSuite tests

How was this patch tested?

update unit tests

@zuotingbing zuotingbing changed the title [SPARK-20338]Spaces in spark.eventLog.dir are not correctly handled [SPARK-20338][CORE]Spaces in spark.eventLog.dir are not correctly handled Jun 13, 2017
@vanzin
Copy link
Copy Markdown
Contributor

vanzin commented Jun 15, 2017

ok to test

@SparkQA
Copy link
Copy Markdown

SparkQA commented Jun 16, 2017

Test build #78130 has finished for PR 18285 at commit a037917.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Jun 16, 2017

Test build #78144 has finished for PR 18285 at commit 536a445.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Copy Markdown
Contributor

vanzin commented Jun 16, 2017

LGTM, merging to master.

@asfgit asfgit closed this in edcb878 Jun 16, 2017
@zuotingbing
Copy link
Copy Markdown
Author

Thanks @vanzin !

@zuotingbing zuotingbing deleted the spark-resolveURI branch June 22, 2017 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants