[SPARK-21045][PYSPARK] Fixed executor blocked because of traceback.format_exc throw UnicodeDecodeError #18261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataknocker
changed the title
|
Can one of the admins verify this patch? |
HyukjinKwon
reviewed
Jun 10, 2017
| try: | ||
| write_int(SpecialLengths.PYTHON_EXCEPTION_THROWN, outfile) | ||
| write_with_length(traceback.format_exc().encode("utf-8"), outfile) | ||
| write_with_length(traceback.format_exc(), outfile) |
Member
There was a problem hiding this comment.
Does this work with Python2 and 3+?
Author
There was a problem hiding this comment.
It slove problem in Python 2 but cause blocked in Python 3.
I have new pr in #18262 used try except.
I will close this pr.
dataknocker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remove encode utf8 to traceback.format_exc()
How was this patch tested?
We can run in pyspark:
spark = SparkSession.builder.master('local').getOrCreate()
rdd = spark.sparkContext.parallelize(['中']).map(lambda x: x.encode("utf8"))
rdd.count()
Before fixed this bug, this program will be blocked.
After fixed this bug, this program will throw exception expected.