[SPARK-19937] Collect metrics for remote bytes read to disk during shuffle. #18249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #77840 has finished for PR 18249 at commit
|
jinxing64
changed the title
vanzin
reviewed
Jun 15, 2017
Contributor
vanzin
left a comment
vanzin
left a comment
There was a problem hiding this comment.
Looks ok. At first I wasn't really sold on the name but can't think of something better either.
project/MimaExcludes.scala
Outdated
| lazy val v23excludes = v22excludes ++ Seq( | ||
| // [SPARK-20495][SQL] Add StorageLevel to cacheTable API | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.cacheTable") | ||
| ) ++ Seq( |
Contributor
There was a problem hiding this comment.
Could you follow the same style as v22excludes, which avoids this extra line?
|
Test build #78140 has finished for PR 18249 at commit
|
Author
|
@vanzin |
Contributor
|
I was just waiting in case anyone else wanted to comment. LGTM, merging to master. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 29, 2017
…uffle. In current code(apache#16989), big blocks are shuffled to disk. This pr proposes to collect metrics for remote bytes fetched to disk. Author: jinxing <[email protected]> Closes apache#18249 from jinxing64/SPARK-19937.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current code(#16989), big blocks are shuffled to disk.
This pr proposes to collect metrics for remote bytes fetched to disk.