[SPARK-21006][TESTS] Create rpcEnv and run later needs shutdown and awaitTermination #18226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Jun 7, 2017
Signed-off-by: 10087686 <[email protected]>
Contributor
Author
|
ok, I have re submit, Thanks for reviewing @srowen |
Contributor
|
ok to test |
|
Test build #77803 has finished for PR 18226 at commit
|
Member
|
Merged to master |
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2017
…kerSuite ## What changes were proposed in this pull request? Create rpcEnv and run later needs shutdown. as #18226 ## How was this patch tested? unit test Author: liuxian <[email protected]> Closes #18259 from 10110346/wip-lx-0610.
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
…kerSuite ## What changes were proposed in this pull request? Create rpcEnv and run later needs shutdown. as apache#18226 ## How was this patch tested? unit test Author: liuxian <[email protected]> Closes apache#18259 from 10110346/wip-lx-0610.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 10087686 [email protected]
What changes were proposed in this pull request?
When run test("port conflict") case, we need run anotherEnv.shutdown() and anotherEnv.awaitTermination() for free resource.
(Please fill in changes proposed in this fix)
How was this patch tested?
run RpcEnvSuit.scala Utest
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.