tests for JoinTypes#18219
Closed
BartekH wants to merge 2 commits intoapache:masterfrom
BartekH:patch-2
Closed
Conversation
tests for JoinType object
|
Can one of the admins verify this patch? |
gatorsmile
reviewed
Jun 6, 2017
| @@ -0,0 +1,44 @@ | |||
| package org.apache.spark.sql.catalyst.plans | |||
Member
There was a problem hiding this comment.
You also need to add the license.
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
add Apache license on the top of file
Member
|
@BartekH can you please close this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests for JoinType object
What changes were proposed in this pull request?
Tests for this code have been suggested during discussion on another problem,
#17985
How was this patch tested?
Tests were performed locally.
Please review http://spark.apache.org/contributing.html before opening a pull request.