Skip to content

[SPARK-20945] Fix TID key not found in TaskSchedulerImpl #18171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liupc wants to merge 3 commits into from
Closed

[SPARK-20945] Fix TID key not found in TaskSchedulerImpl #18171

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e35879
Fix tid key not found in TaskSchedulerImpl
Jun 1, 2017
6d78a71
Merge branch 'master' into Fix-tid-key-not-found-in-TaskSchedulerImpl
Jun 1, 2017
c4fff63
update
Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,10 @@ private[spark] class TaskSchedulerImpl private[scheduler](
// 2. The task set manager has been created but no tasks has been scheduled. In this case,
// simply abort the stage.
tsm.runningTasksSet.foreach { tid =>
val execId = taskIdToExecutorId(tid)
backend.killTask(tid, execId, interruptThread, reason = "stage cancelled")
if (taskIdToExecutorId.contains(tid)) {
val execId = taskIdToExecutorId(tid)
backend.killTask(tid, execId, interruptThread)

@srowen srowen Jun 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you lost the value of "reason" here.
It's not a big deal but you could also write:

taskIdToExecutorId.get(tid).foreach(execId => backend.killTask(tid, execId, interruptThread, reason = "stage cancelled"))

@liupc liupc Jun 2, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will update soon, thanks!

}
}
tsm.abort("Stage %s cancelled".format(stageId))
logInfo("Stage %d was cancelled".format(stageId))
Expand Down