Skip to content

[SPARK-20942][WEB-UI]The title style about field is error in the history server web ui. #18170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guoxiaolongzte wants to merge 38 commits into from
Closed

[SPARK-20942][WEB-UI]The title style about field is error in the history server web ui. #18170

Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
d383efb
[SPARK-20177]Document about compression way has some little detail ch…
Mar 31, 2017
3059013
[SPARK-20177] event log add a space
Apr 1, 2017
555cef8
'/applications/[app-id]/jobs' in rest api,status should be [running|s…
Apr 2, 2017
46bb1ad
Merge branch 'master' of https://github.com/apache/spark into SPARK-2…
Apr 5, 2017
0efb0dd
[SPARK-20218]'/applications/[app-id]/stages' in REST API,add descript…
Apr 5, 2017
0e37fde
[SPARK-20218] '/applications/[app-id]/stages/[stage-id]' in REST API,…
Apr 5, 2017
52641bb
Merge branch 'SPARK-20218'
Apr 7, 2017
d3977c9
Merge branch 'master' of https://github.com/apache/spark
Apr 8, 2017
137b90e
Merge branch 'master' of https://github.com/apache/spark
Apr 10, 2017
0fe5865
Merge branch 'SPARK-20190' of https://github.com/guoxiaolongzte/spark
Apr 10, 2017
cf6f42a
Merge branch 'master' of https://github.com/apache/spark
Apr 10, 2017
685cd6b
Merge branch 'master' of https://github.com/apache/spark
Apr 14, 2017
c716a92
Merge branch 'master' of https://github.com/apache/spark
Apr 17, 2017
679cec3
Merge branch 'master' of https://github.com/apache/spark
Apr 19, 2017
3c9387a
Merge branch 'master' of https://github.com/apache/spark
Apr 19, 2017
cb71f44
Merge branch 'master' of https://github.com/apache/spark
Apr 20, 2017
ce92a74
Merge branch 'master' of https://github.com/apache/spark
Apr 21, 2017
dd64342
Merge branch 'master' of https://github.com/apache/spark
Apr 21, 2017
bffd2bd
Merge branch 'master' of https://github.com/apache/spark
Apr 28, 2017
588d42a
Merge branch 'master' of https://github.com/apache/spark
Apr 28, 2017
4bbeee1
Merge branch 'master' of https://github.com/apache/spark
May 2, 2017
362e5ad
Merge branch 'master' of https://github.com/apache/spark
May 3, 2017
4ed5e00
增加代码
May 11, 2017
d871e01
Merge branch 'master' of https://github.com/apache/spark
May 11, 2017
a1f7759
Merge branch 'master' of https://github.com/apache/spark
May 11, 2017
dc56cdf
Merge branch 'master' of https://github.com/apache/spark
May 12, 2017
c999cf7
Merge branch 'master' of https://github.com/apache/spark
May 16, 2017
685dd8c
Merge branch 'master' of https://github.com/apache/spark
May 16, 2017
b744ceb
Merge branch 'master' of https://github.com/apache/spark
May 17, 2017
84a50f2
Merge branch 'master' of https://github.com/apache/spark
May 18, 2017
402b5f7
Merge branch 'master' of https://github.com/apache/spark
May 23, 2017
4867780
Merge branch 'master' of https://github.com/apache/spark
May 25, 2017
c1b1e38
Merge branch 'master' of https://github.com/apache/spark
May 26, 2017
85752db
Merge branch 'master' of https://github.com/apache/spark
May 31, 2017
172c872
Merge branch 'master' of https://github.com/apache/spark
Jun 1, 2017
26b0145
[SPARK-20942]The title style about field is error and the search fiel…
Jun 1, 2017
5fc7c59
[SPARK-20942]FIX the spelling error
Jun 1, 2017
446a584
[SPARK-20942]'top' replace 'above'
Jun 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
<thead>
<tr>
<th>
<span data-toggle="tooltip" data-placement="right" title="ID of the application.">
<span data-toggle="tooltip" data-placement="right" title="ID of this application.">
App ID
</span>
</th>
<th>
<span data-toggle="tooltip" data-placement="above" title="Name of the application.">
<span data-toggle="tooltip" data-placement="right" title="Name of this application.">

@ajbozarth ajbozarth Jun 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason to change this

@guoxiaolongzte guoxiaolongzte Jun 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, you mean, 'the application' is changed to 'this application'? Or 'above' to 'right'?

First, consistent with other field titles.
11

Second, The tooltip placement to "above", the prompt position will always be displayed on the APP ID, rather than on the current title.

1

App Name
</span>
</th>
<th class="attemptIDSpan">
<span data-toggle="tooltip" data-placement="above" title="The attempt ID of this application since one application might be launched several times">
<span data-toggle="tooltip" data-placement="right" title="The attempt ID of this application since one application might be launched several times">

@jerryshao jerryshao Jun 1, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to change the tooltip placement to "right", any particular issue here?

@guoxiaolongzte guoxiaolongzte Jun 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip placement to "above", the prompt position will always be displayed on the APP ID, rather than on the current title.

1

@ajbozarth ajbozarth Jun 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I found the issue, above is incorrect, what we want is top

@guoxiaolongzte guoxiaolongzte Jun 1, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it and test it. Thanks.

@guoxiaolongzte guoxiaolongzte Jun 1, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the error. ‘top’ replace ‘above’. The test result is OK. Thanks.

Attempt ID
</span>
</th>
Expand All @@ -40,12 +40,12 @@
</span>
</th>
<th class="completedColumn">
<span data-toggle="tooltip" data-placement="above" title="The completed time of this application.">
<span data-toggle="tooltip" data-placement="right" title="The completed time of this application.">
Completed
</span>
</th>
<th>
<span data-toggle="tooltip" data-placement="above" title="The duration time of this application.">
<span data-toggle="tooltip" data-placement="right" title="The duration time of this application.">
Duration
</span>
</th>
Expand All @@ -55,12 +55,12 @@
</span>
</th>
<th>
<span data-toggle="tooltip" data-placement="above" title="The timestamp of the last updating on this application">
<span data-toggle="tooltip" data-placement="right" title="The timestamp of the last updating on this application">
Last Updated
</span>
</th>
<th>
<span data-toggle="tooltip" data-placement="above" title="Download the event log for this application">
<span data-toggle="tooltip" data-placement="right" title="Download the event log for this application">
Event Log
</span>
</th>
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/org/apache/spark/ui/static/historypage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ $(document).ready(function() {
}

$(selector).DataTable(conf);
$('#hisotry-summary [data-toggle="tooltip"]').tooltip();
$('#history-summary-table [data-toggle="tooltip"]').tooltip();

@ajbozarth ajbozarth Jun 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just #history-summary is still correct here, but nice catch on the spelling error.

@guoxiaolongzte guoxiaolongzte Jun 1, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is the spelling error. I did not notice that I thought it was ID wrong. I will fix it and test it.

@guoxiaolongzte guoxiaolongzte Jun 1, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the spelling error. The test result is OK. But historypage-template.html still need to be modified. Thanks.

});
});
});