Skip to content

[SPARK-20877][SPARKR][WIP] add timestamps to test runs#18104

Closed
felixcheung wants to merge 10 commits intoapache:masterfrom
felixcheung:rtimetest
Closed

[SPARK-20877][SPARKR][WIP] add timestamps to test runs#18104
felixcheung wants to merge 10 commits intoapache:masterfrom
felixcheung:rtimetest

Conversation

@felixcheung
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

to investigate how long they run

How was this patch tested?

Jenkins, AppVeyor

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 25, 2017

Test build #77330 has finished for PR 18104 at commit dab72a6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 25, 2017

Test build #77336 has finished for PR 18104 at commit 313dcbc.

  • This patch fails R style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 25, 2017

Test build #77339 has finished for PR 18104 at commit a72ab8c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 26, 2017

Test build #77403 has finished for PR 18104 at commit 3273a0d.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 26, 2017

Test build #77405 has finished for PR 18104 at commit 1d18d7b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 26, 2017

Test build #77406 has finished for PR 18104 at commit 21ca8f0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 27, 2017

Test build #77474 has finished for PR 18104 at commit 9056b75.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 28, 2017

Test build #77481 has finished for PR 18104 at commit 9e848a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Copy Markdown
Member Author

AppVeyor test portion took about 5 min https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1361-master

@felixcheung
Copy link
Copy Markdown
Member Author

perhaps we could cut down a lot more tests though http://r-pkgs.had.co.nz/tests.html#test-cran
if the target is under 1 min...

@shivaram
Copy link
Copy Markdown
Contributor

@felixcheung This is very cool. Let me try this on a windows VM and winbuilder and get back to you.

@marmbrus
Copy link
Copy Markdown
Contributor

Ping? I'd like to cut the next RC.

@felixcheung
Copy link
Copy Markdown
Member Author

We were talking about another more drastic approach but what we have here would be improvement.

I'm reverting as-cran so this can go in (after another round of tests), and I think then should unblock RC.

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 31, 2017

Test build #77566 has finished for PR 18104 at commit 1392392.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Copy Markdown
Member Author

ok passes. @shivaram what do you think about this?

@shivaram
Copy link
Copy Markdown
Contributor

LGTM. Thanks @felixcheung for the update and @marmbrus for the ping

asfgit pushed a commit that referenced this pull request May 31, 2017
to investigate how long they run

Jenkins, AppVeyor

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes #18104 from felixcheung/rtimetest.

(cherry picked from commit 382fefd)
Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
@asfgit asfgit closed this in 382fefd May 31, 2017
@felixcheung
Copy link
Copy Markdown
Member Author

@shivaram did you get the chance to look at refactoring tests we discussed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants