Skip to content

[SPARK-20875] Spark should print the log when the directory has been deleted #18102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liu-zhaokun wants to merge 6 commits into from
Closed

[SPARK-20875] Spark should print the log when the directory has been deleted #18102

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc6d2ad
[SPARK-20875] Spark should print the log when the directory has been …
liu-zhaokun May 25, 2017
9d0f507
change the log level
liu-zhaokun May 25, 2017
10db5ce
fix the string message
liu-zhaokun May 25, 2017
9c96f25
use string interpolation
liu-zhaokun May 25, 2017
5d32be9
change the lcoation of logTrace
liu-zhaokun May 25, 2017
1a5853f
change the spaced indentation
liu-zhaokun May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/scala/org/apache/spark/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,6 +1004,7 @@ private[spark] object Utils extends Logging {
for (child <- listFilesSafely(file)) {
try {
deleteRecursively(child)
logTrace(file.getAbsolutePath + " has been deleted")

@srowen srowen May 25, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, why not s"${file.getAbsolutePath} has been deleted"? it's actually important for a log trace statement

} catch {
// In case of multiple exceptions, only last one will be thrown
case ioe: IOException => savedIOException = ioe
Expand Down