Skip to content

[Spark-20873][SQL] Improve the error message for unsupported Column Type #18097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubenljanssen wants to merge 3 commits into from
Closed

[Spark-20873][SQL] Improve the error message for unsupported Column Type #18097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69369fb
added typename and corresponding unit test
rubenljanssen May 24, 2017
f53de3e
updated imports
rubenljanssen May 24, 2017
90433a9
added suggestions
rubenljanssen May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnType.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ private[columnar] object ColumnType {
case struct: StructType => STRUCT(struct)
case udt: UserDefinedType[_] => apply(udt.sqlType)
case other =>
throw new Exception(s"Unsupported type: $other")
throw new Exception(s"Unsupported type: ${other.simpleString}")
}
}
}
14 changes: 14 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnTypeSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,4 +144,18 @@ class ColumnTypeSuite extends SparkFunSuite with Logging {
ColumnType(DecimalType(19, 0))
}
}

test("show type name in type mismatch error") {
val invalidType = new DataType {
override def defaultSize: Int = 1
override private[spark] def asNullable: DataType = this
override def typeName: String = "invalid type name"
}

val message = intercept[java.lang.Exception] {
ColumnType(invalidType)
}.getMessage

assert(message.contains("Unsupported type: invalid type name"))
}
}