[Minor] document edge case of updateFunc usage#18088
Closed
emilyselwood wants to merge 2 commits intoapache:masterfrom
Closed
[Minor] document edge case of updateFunc usage#18088emilyselwood wants to merge 2 commits intoapache:masterfrom
emilyselwood wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
reviewed
May 25, 2017
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Sounds it changes the permission from ...
-rw-r--r-- ... PairDStreamFunctions.scalato an executable ...
-rwxr-xr-x ... PairDStreamFunctions.scala*
Contributor
Author
|
Good catch @HyukjinKwon Sorry about that. |
|
Test build #3762 has finished for PR 18088 at commit
|
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Include documentation of the fact that the updateFunc is sometimes called with no new values. This is documented in the main documentation here: https://spark.apache.org/docs/latest/streaming-programming-guide.html#updatestatebykey-operation however from the docs included with the code it is not clear that this is the case.
How was this patch tested?
PR only changes comments. Confirmed code still builds.