[SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpressionsSuite #18082

10110346 · 2017-05-24T01:24:49Z

What changes were proposed in this pull request?

add test case to MathExpressionsSuite as #17906

How was this patch tested?

unit test cases

gatorsmile · 2017-05-24T03:05:00Z

sql/core/src/test/resources/sql-tests/inputs/mathFunctions.sql

add a new line here

gatorsmile · 2017-05-24T03:06:01Z

sql/core/src/test/resources/sql-tests/inputs/mathFunctions.sql

To -- cot

10110346 · 2017-05-24T03:23:28Z

Done. Should i delete the unit test case from MathFunctionsSuite.scala?
@gatorsmile

rxin · 2017-05-24T10:05:15Z

Hm I'm not sure if it is a good idea to run so many "unit test" style tests for expressions in the end to end suites. It takes a lot of time than just running unit tests.

gatorsmile · 2017-05-24T18:38:16Z

@10110346 Could you move them to MathExpressionsSuite, based on @rxin 's comments? Thanks!

10110346 · 2017-05-25T00:43:44Z

@gatorsmile OK,i will do,thanks

10110346 · 2017-06-01T09:17:39Z

@gatorsmile Please review it again,thanks

gatorsmile · 2017-06-01T17:00:59Z

...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala

revert this back

gatorsmile · 2017-06-01T17:01:31Z

...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala

indent issues.

gatorsmile · 2017-06-01T17:01:48Z

ok to test

SparkQA · 2017-06-01T17:04:35Z

Test build #77647 has finished for PR 18082 at commit 5b747ef.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2017-06-02T03:22:09Z

Test build #77663 has finished for PR 18082 at commit d9d245a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

10110346 · 2017-06-05T10:35:29Z

Test passed, thanks. @gatorsmile

SparkQA · 2017-06-09T03:44:00Z

Test build #77834 has finished for PR 18082 at commit 0ca63be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-06-10T23:47:51Z

sql/core/src/test/resources/sql-tests/inputs/operators.sql

After rethinking it, maybe we should keep this file untouched in this PR. The reason is we still can check the type promotion logics here.

Yeah, we still should add the test cases in MathExpressionsSuite.scala

10110346 · 2017-06-11T10:13:52Z

@gatorsmile ok,i will modify and resubmit

SparkQA · 2017-06-12T04:22:29Z

Test build #77904 has finished for PR 18082 at commit 4e20839.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-06-12T05:29:30Z

Thanks! Merging to master.

## What changes were proposed in this pull request? add test case to MathExpressionsSuite as apache#17906 ## How was this patch tested? unit test cases Author: liuxian <[email protected]> Closes apache#18082 from 10110346/wip-lx-0524.

10110346 changed the title ~~[SPARK-20665][SQL][FOLLOW-UP]move test case to SQLQueryTestSuite~~ [SPARK-20665][SQL][FOLLOW-UP]Move test case to SQLQueryTestSuite May 24, 2017

gatorsmile reviewed May 24, 2017

View reviewed changes

sql/core/src/test/resources/sql-tests/inputs/mathFunctions.sql Outdated

Copy link

Member

gatorsmile May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new line here

gatorsmile reviewed May 24, 2017

View reviewed changes

sql/core/src/test/resources/sql-tests/inputs/mathFunctions.sql Outdated

Copy link

Member

gatorsmile May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To -- cot

10110346 force-pushed the wip-lx-0524 branch 2 times, most recently from 542430b to ec0fa63 Compare May 24, 2017 03:17

10110346 force-pushed the wip-lx-0524 branch from ec0fa63 to b12167b Compare May 24, 2017 11:34

10110346 force-pushed the wip-lx-0524 branch from b12167b to cf0965a Compare May 26, 2017 08:14

10110346 changed the title ~~[SPARK-20665][SQL][FOLLOW-UP]Move test case to SQLQueryTestSuite~~ [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpressionsSuite May 26, 2017

10110346 mentioned this pull request May 27, 2017

[SPARK-20876][SQL]If the input parameter is float type for ceil or floor,the result is not we expected #18103

Closed

10110346 closed this May 27, 2017

10110346 reopened this May 28, 2017

10110346 force-pushed the wip-lx-0524 branch 3 times, most recently from ec8fc33 to 5b747ef Compare June 1, 2017 08:53

gatorsmile reviewed Jun 1, 2017

View reviewed changes

...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala Outdated

Copy link

Member

gatorsmile Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this back

gatorsmile reviewed Jun 1, 2017

View reviewed changes

...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala Outdated

Copy link

Member

gatorsmile Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent issues.

10110346 force-pushed the wip-lx-0524 branch from 5b747ef to d9d245a Compare June 2, 2017 00:54

10110346 force-pushed the wip-lx-0524 branch from d9d245a to 0ca63be Compare June 9, 2017 01:22

gatorsmile reviewed Jun 10, 2017

View reviewed changes

Fix:move test case to MathExpressionsSuite

4e20839

10110346 force-pushed the wip-lx-0524 branch from 0ca63be to 4e20839 Compare June 12, 2017 01:38

asfgit closed this in d140918 Jun 12, 2017

[SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpressionsSuite #18082

[SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpressionsSuite #18082

Uh oh!

Conversation

10110346 commented May 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

gatorsmile May 24, 2017

Choose a reason for hiding this comment

Uh oh!

gatorsmile May 24, 2017

Choose a reason for hiding this comment

Uh oh!

10110346 commented May 24, 2017

Uh oh!

rxin commented May 24, 2017

Uh oh!

gatorsmile commented May 24, 2017

Uh oh!

10110346 commented May 25, 2017

Uh oh!

10110346 commented Jun 1, 2017

Uh oh!

gatorsmile Jun 1, 2017

Choose a reason for hiding this comment

Uh oh!

gatorsmile Jun 1, 2017

Choose a reason for hiding this comment

Uh oh!

gatorsmile commented Jun 1, 2017

Uh oh!

SparkQA commented Jun 1, 2017

Uh oh!

SparkQA commented Jun 2, 2017

Uh oh!

10110346 commented Jun 5, 2017

Uh oh!

SparkQA commented Jun 9, 2017

Uh oh!

gatorsmile Jun 10, 2017

Choose a reason for hiding this comment

Uh oh!

10110346 commented Jun 11, 2017

Uh oh!

SparkQA commented Jun 12, 2017

Uh oh!

gatorsmile commented Jun 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

10110346 commented May 24, 2017 •

edited

Loading