-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-20855][Docs][DStream] Update the Spark kinesis docs to use the KinesisInputDStream builder instead of deprecated KinesisUtils #18071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #77250 has finished for PR 18071 at commit
|
|
Hey @budde , drawing your attention here please.
|
|
Hi @yssharma, is it still WIP? I think we should make the PR on the mergable state at least. |
|
@HyukjinKwon The PR is ready. Just waiting for some 👍 from the reviewers. |
|
It looks the last test was failed by style checking. Would you have some time to fix them up? |
|
I noticed that now. Yes I will post an updated patch today. Thanks @HyukjinKwon |
1e7e879 to
9d50bd9
Compare
|
Test build #79904 has finished for PR 18071 at commit
|
|
Updated the patch @HyukjinKwon . Thanks for the note. 👍 |
|
I'm OK to merge something like this but don't know about the kinesis integration, not enough to review the content. Who could give it a second look, @budde ? |
budde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. There are slight inconsistencies in the indent level between the old code samples in streaming-kinesis-integration.md and the new one but I'm not too familiar with how this gets rendered so perhaps this doesn't make a difference. Thanks for picking up my slack and updating the docs BTW— I should've really gotten to this when I added the builder interface.
|
Merged to master |
What changes were proposed in this pull request?
The examples and docs for Spark-Kinesis integrations use the deprecated KinesisUtils. We should update the docs to use the KinesisInputDStream builder to create DStreams.
How was this patch tested?
The patch primarily updates the documents. The patch will also need to make changes to the Spark-Kinesis examples. The examples need to be tested.