Skip to content

[SPARK-20713][Spark Core] Convert CommitDenied to TaskKilled. #18070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lycplus wants to merge 5 commits into from
Closed

[SPARK-20713][Spark Core] Convert CommitDenied to TaskKilled. #18070

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3467d5d
Convert CommitDenied to TaskKilled.
lycplus May 23, 2017
f886077
Convert the CommitDeniedException in the right place.
lycplus May 26, 2017
8b47112
Remove unused imports.
lycplus May 26, 2017
ff93ade
Update toTaskFailedReason to TaskCommitDeniedReason.
lycplus May 27, 2017
99b2f8c
Let TaskCommitDenied extends TaskKilled.
lycplus Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/executor/Executor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ private[spark] class Executor(
case CausedBy(cDE: CommitDeniedException) =>
val reason = cDE.toTaskFailedReason

@tgravescs tgravescs May 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably change this to be toTaskCommitDeniedReason since its not failed anymore.

setTaskFinishedAndClearInterruptStatus()
execBackend.statusUpdate(taskId, TaskState.FAILED, ser.serialize(reason))
execBackend.statusUpdate(taskId, TaskState.KILLED, ser.serialize(reason))

case t: Throwable =>
// Attempt to exit cleanly by informing the driver of our failure.
Expand Down