[SPARK-20835][Core]It should exit directly when the --total-executor-cores parameter is setted less than 0 when submit a application

[eatoncys]

What changes were proposed in this pull request?

In my test, the submitted app running with out an error when the --total-executor-cores less than 0
and given the warnings:
"2017-05-22 17:19:36,319 WARN org.apache.spark.scheduler.TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources";

It should exit directly when the --total-executor-cores parameter is setted less than 0 when submit a application
(Please fill in changes proposed in this fix)

How was this patch tested?

Run the ut tests
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

[srowen]

I agree it should fail faster, but shouldn't many args be validated here? CC @vanzin

[eatoncys]

@srowen The other parameters are validated at some other places, for example, the --executor-memory parameter is validated at org.apache.spark.memory.UnifiedMemoryManager$.getMaxMemory, the app can exit with error: "java.lang.NumberFormatException" if it is a negative number. But the --total-executor-cores parameter is not validated at anywhere, the app can not exit if it is a negative number.

[srowen]

Yeah but maybe a good idea to valid all these aren't negative upfront. Fail faster and more consistently.

[eatoncys]

@srowen Thank you for suggestion. I have validated other numerical parameters here, any other suggestion?

[srowen]

Seems reasonable to me. I wonder if @vanzin wants to comment?

[SparkQA]

Test build #3750 has finished for PR 18060 at commit 4c4bfbb.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[eatoncys]

Jenkins, retest this please

[eatoncys]

@SparkQA Retest this please,thanks!

[SparkQA]

Test build #3757 has finished for PR 18060 at commit eae0f3d.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #3760 has finished for PR 18060 at commit caacdc0.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Merged to master