Skip to content

Add "full_outer" name to join types #17985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BartekH wants to merge 6 commits into from
Closed

Add "full_outer" name to join types #17985

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4b8557
Add "full_outer" name to join types
BartekH May 15, 2017
93d905c
Update joinTypes.scala
BartekH Jun 6, 2017
71d65e8
Create JoinTypesTest.scala
BartekH Jun 6, 2017
7bea0ad
Update JoinTypesTest.scala
BartekH Jun 6, 2017
aed0a06
Merge pull request #1 from BartekH/patch-2
BartekH Jun 7, 2017
9fc9a0a
remove apply method from JoinType execution
BartekH Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import org.apache.spark.sql.catalyst.expressions.Attribute
object JoinType {
def apply(typ: String): JoinType = typ.toLowerCase(Locale.ROOT).replace("_", "") match {
case "inner" => Inner
case "outer" | "full" | "fullouter" => FullOuter
case "outer" | "full" | "fullouter" | "full_outer" => FullOuter

@sameeragarwal sameeragarwal May 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @wzhfy points out, given that we remove underscores, this matching case is unnecessary. The same is true for left_outer, right_outer and left_semi.

case "leftouter" | "left" => LeftOuter
case "rightouter" | "right" => RightOuter
case "leftsemi" => LeftSemi
Expand All @@ -33,7 +33,7 @@ object JoinType {
case _ =>
val supported = Seq(
"inner",
"outer", "full", "fullouter",
"outer", "full", "fullouter", "full_outer",
"leftouter", "left",
"rightouter", "right",
"leftsemi",
Expand Down