Skip to content

[SPARK-20620][TEST]Improve some unit tests for NullExpressionsSuite and TypeCoercionSuite #17880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
10110346 wants to merge 1 commit into from
Closed

[SPARK-20620][TEST]Improve some unit tests for NullExpressionsSuite and TypeCoercionSuite #17880

10110346 wants to merge 1 commit into from

Conversation

@10110346
Copy link
Contributor

@10110346 10110346 commented May 6, 2017 •
edited
Loading

What changes were proposed in this pull request?

add more datatype for some unit tests

How was this patch tested?

unit tests

gatorsmile
gatorsmile reviewed May 6, 2017
View reviewed changes
...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala Outdated
Copy link
Member

@gatorsmile gatorsmile May 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is part of the test case test("coalesce casts") in TypeCoercionSuite. If you want, you can improve that test case.

gatorsmile
gatorsmile reviewed May 6, 2017
View reviewed changes
...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala Outdated
Copy link
Member

@gatorsmile gatorsmile May 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same for this. It is being covered by the test case test("type coercion for If") in TypeCoercionSuite. If you want, you can improve that test case.

@10110346
Copy link
Contributor Author

10110346 commented May 7, 2017

@gatorsmile thanks,l will do it.

@10110346 10110346 force-pushed the wip_lx_0506 branch 2 times, most recently from c75c36b to 3f99750 Compare May 8, 2017 03:42
@10110346 10110346 changed the title [SPARK-20620][TEST]Add some unit tests into NullExpressionsSuite [SPARK-20620][TEST]Improve some unit tests for NullExpressionsSuite and TypeCoercionSuite May 8, 2017
HyukjinKwon
HyukjinKwon reviewed May 8, 2017
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala Outdated
Copy link
Member

@HyukjinKwon HyukjinKwon May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I guess this should be longLit )

@SparkQA
Copy link

SparkQA commented May 8, 2017

Test build #3699 has finished for PR 17880 at commit 3f99750.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@10110346
Copy link
Contributor Author

10110346 commented May 19, 2017

I have modify Scala style.
Test is not started, could you help trigger it,thanks @HyukjinKwon @gatorsmile

@SparkQA
Copy link

SparkQA commented May 19, 2017

Test build #3731 has finished for PR 17880 at commit 3110f0f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented May 29, 2017

retest this please

@gatorsmile
Copy link
Member

gatorsmile commented May 29, 2017

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented May 29, 2017

Test build #77507 has finished for PR 17880 at commit 3110f0f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@10110346
Copy link
Contributor Author

10110346 commented Jun 5, 2017

Test passed, thanks. @gatorsmile

@gatorsmile
Copy link
Member

gatorsmile commented Jun 10, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Jun 10, 2017

Test build #77871 has finished for PR 17880 at commit 5b19b91.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 5301a19 Jun 10, 2017
dataknocker pushed a commit to dataknocker/spark that referenced this pull request Jun 16, 2017
@10110346
[SPARK-20620][TEST] Improve some unit tests for NullExpressionsSuite …
cdb26eb 
…and TypeCoercionSuite

## What changes were proposed in this pull request?
add more  datatype for some unit tests

## How was this patch tested?
unit tests

Author: liuxian <[email protected]>

Closes apache#17880 from 10110346/wip_lx_0506.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon left review comments

@gatorsmile gatorsmile gatorsmile left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@10110346 @SparkQA @gatorsmile @HyukjinKwon