[SPARK-20541][SPARKR][SS] support awaitTermination without timeout #17815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76335 has finished for PR 17815 at commit
|
|
Test build #76336 has finished for PR 17815 at commit
|
shivaram
reviewed
May 1, 2017
|
|
||
| stopQuery(q) | ||
| expect_true(awaitTermination(q, 1)) | ||
| expect_error(awaitTermination(q), NA) |
Contributor
There was a problem hiding this comment.
Why will this generate an error ?
Member
Author
There was a problem hiding this comment.
NA means expects no error ;)
yea, it's not very intuitive. There is no return value in this case, so just checking to make sure it doesn't throw an error
Contributor
|
LGTM. Minor comment |
asfgit
pushed a commit
that referenced
this pull request
May 1, 2017
## What changes were proposed in this pull request? Add without param for timeout - will need this to submit a job that runs until stopped Need this for 2.2 ## How was this patch tested? manually, unit test Author: Felix Cheung <[email protected]> Closes #17815 from felixcheung/rssawaitinfinite. (cherry picked from commit a355b66) Signed-off-by: Felix Cheung <[email protected]>
Member
Author
|
merged to master/2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add without param for timeout - will need this to submit a job that runs until stopped
Need this for 2.2
How was this patch tested?
manually, unit test