-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-20514][CORE] Upgrade Jetty to 9.3.11.v20160721 #17790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upgrade Jetty so it can work with Hadoop 3 (alpha 2 release, in particular). Without this change, because of incompatibily between Jetty versions, Spark fails to compile when built against Hadoop 3
|
I am running unit tests locally and while the run hasn't finished, it's looking pretty good so far. I think it'd be good to get Jenkins to run the tests here anyways so putting a PR sooner than later. |
| <parquet.version>1.8.2</parquet.version> | ||
| <hive.parquet.version>1.6.0</hive.parquet.version> | ||
| <jetty.version>9.2.16.v20160414</jetty.version> | ||
| <jetty.version>9.3.11.v20160721</jetty.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title says one thing but your code says another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks, there was some confusion about this. I have fixed the JIRA title and the PR title to match up with the actual code - which uses the exact same version as Apache Hadoop (9.3.11.v20160721).
|
CC @zsxwing as it touches Jetty. |
Jetty is shaded in Spark. |
|
cc @yhuai |
|
Test build #76244 has finished for PR 17790 at commit
|
|
LGTM. |
|
Thanks for the review! |
|
If there are no more concerns I'll push this in the PM. |
|
LGTM. |
|
Merging to master / 2.2. |
Upgrade Jetty so it can work with Hadoop 3 (alpha 2 release, in particular). Without this change, because of incompatibily between Jetty versions, Spark fails to compile when built against Hadoop 3 ## How was this patch tested? Unit tests being run. Author: Mark Grover <[email protected]> Closes #17790 from markgrover/spark-20514. (cherry picked from commit 5d71f3d) Signed-off-by: Marcelo Vanzin <[email protected]>
Upgrade Jetty so it can work with Hadoop 3 (alpha 2 release, in particular).
Without this change, because of incompatibily between Jetty versions,
Spark fails to compile when built against Hadoop 3
How was this patch tested?
Unit tests being run.