Skip to content

[SPARK-20483][MINOR] Test for Mesos Coarse mode may starve other Mesos frameworks #17788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgshep wants to merge 1 commit into from
Closed

[SPARK-20483][MINOR] Test for Mesos Coarse mode may starve other Mesos frameworks #17788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions ...la/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,40 @@ class MesosCoarseGrainedSchedulerBackendSuite extends SparkFunSuite
verifyDeclinedOffer(driver, createOfferId("o2"), true)
}

test("mesos declines offers with a filter when maxCores not a multiple of executor.cores") {
val maxCores = 4
val executorCores = 3
setBackend(Map(
"spark.cores.max" -> maxCores.toString,
"spark.executor.cores" -> executorCores.toString
))
val executorMemory = backend.executorMemory(sc)
offerResources(List(
Resources(executorMemory, maxCores + 1),
Resources(executorMemory, maxCores + 1)
))
verifyTaskLaunched(driver, "o1")
verifyDeclinedOffer(driver, createOfferId("o2"), true)
}

test("mesos declines offers with a filter when reached spark.cores.max with executor.cores") {
val maxCores = 4
val executorCores = 2
setBackend(Map(
"spark.cores.max" -> maxCores.toString,
"spark.executor.cores" -> executorCores.toString
))
val executorMemory = backend.executorMemory(sc)
offerResources(List(
Resources(executorMemory, maxCores + 1),
Resources(executorMemory, maxCores + 1),
Resources(executorMemory, maxCores + 1)
))
verifyTaskLaunched(driver, "o1")
verifyTaskLaunched(driver, "o2")
verifyDeclinedOffer(driver, createOfferId("o3"), true)
}

test("mesos assigns tasks round-robin on offers") {
val executorCores = 4
val maxCores = executorCores * 2
Expand Down