-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-4899][MESOS] Support for Checkpointing on Coarse Grained Mode #17750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
558ab20
f79326e
80d2838
4622fa8
b51395e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -158,7 +158,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend( | |
| sc.appName, | ||
| sc.conf, | ||
| sc.conf.getOption("spark.mesos.driver.webui.url").orElse(sc.ui.map(_.webUrl)), | ||
| None, | ||
| sc.conf.getOption("spark.mesos.checkpoint").map(_.toBoolean), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're trying to move all config over to https://github.com/apache/spark/blob/master/resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala Please add this there. |
||
| None, | ||
| sc.conf.getOption("spark.mesos.driver.frameworkId") | ||
| ) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,8 +78,8 @@ private[spark] class MesosFineGrainedSchedulerBackend( | |
| sc.appName, | ||
| sc.conf, | ||
| sc.conf.getOption("spark.mesos.driver.webui.url").orElse(sc.ui.map(_.webUrl)), | ||
| Option.empty, | ||
| Option.empty, | ||
| None, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better not to touch this. |
||
| None, | ||
| sc.conf.getOption("spark.mesos.driver.frameworkId") | ||
| ) | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's customize this copy a bit for Spark instead of just copying the protobuf docs. e.g. "tasks" should be "executors" and you should remove the part about "this framework", in place of something about Spark in particular.