[SPARK-20288] Avoid generating the MapStatus by stageId in BasicSchedulerIntegrationSuite#17603
Closed
jinxing64 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-20288] Avoid generating the MapStatus by stageId in BasicSchedulerIntegrationSuite#17603jinxing64 wants to merge 1 commit intoapache:masterfrom
jinxing64 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #75693 has started for PR 17603 at commit |
Author
|
I found this when test #17533. It failed now and then when try to get size of reduce from I'm not sure how to make it better: |
|
Test build #75696 has finished for PR 17603 at commit
|
Author
|
@squito |
Contributor
|
lgtm rerunning tests just to be safe since its been so long |
|
Test build #3768 has finished for PR 17603 at commit
|
Author
|
@squito |
Author
|
Jenkins, retest this please. |
…ulerIntegrationSuite
|
Test build #77569 has finished for PR 17603 at commit
|
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ShuffleId is determined before job submitted. But it's hard to predict stageId by shuffleId.
Stage is created in DAGScheduler(
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L381), but the order is n
ot determined in
HashSet.I added a log(println(s"Creating ShufflMapStage-$id on shuffle-${shuffleDep.shuffleId}")) after (https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L331), when testing BasicSchedulerIntegrationSuite:"multi-stage job". It will print:
Creating ShufflMapStage-0 on shuffle-0
Creating ShufflMapStage-1 on shuffle-2
Creating ShufflMapStage-2 on shuffle-1
Creating ShufflMapStage-3 on shuffle-3
or
Creating ShufflMapStage-0 on shuffle-1
Creating ShufflMapStage-1 on shuffle-3
Creating ShufflMapStage-2 on shuffle-0
Creating ShufflMapStage-3 on shuffle-2
It might be better to avoid generating the MapStatus by stageId.