[SPARK-19991][CORE][YARN] FileSegmentManagedBuffer performance improvement#17567
Closed
srowen wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-19991][CORE][YARN] FileSegmentManagedBuffer performance improvement#17567srowen wants to merge 1 commit intoapache:masterfrom
srowen wants to merge 1 commit intoapache:masterfrom
Conversation
…lt) falls back to default
Member
Author
|
Test build #75609 has finished for PR 17567 at commit
|
Contributor
|
LGTM. |
|
Test build #3646 has finished for PR 17567 at commit
|
Contributor
|
LGTM. |
Member
Author
|
I don't have a benchmark. I was going by your report that this was a hotspot. It is a simple enough change that it seemed OK to make even with minimal runtime benefit. |
Contributor
|
OK, I see. |
Member
Author
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid
NoSuchElementExceptionevery timeConfigProvider.get(val, default)falls back to default. This apparently causes non-trivial overhead in at least one path, and can easily be avoided.See #17329
How was this patch tested?
Existing tests