[SPARK-19518][SQL] IGNORE NULLS in first / last in SQL#17566
Closed
HyukjinKwon wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-19518][SQL] IGNORE NULLS in first / last in SQL#17566HyukjinKwon wants to merge 3 commits intoapache:masterfrom
HyukjinKwon wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
@hvanhovell, could you check if it makes sense please? |
hvanhovell
reviewed
Apr 7, 2017
| /** | ||
| * Create a [[First]] expression. | ||
| */ | ||
| override def visitFirst(ctx: FirstContext): Expression = withOrigin(ctx) { |
Contributor
There was a problem hiding this comment.
NIT: you don't have to check both (the grammar enforces that they both need to be present), either one suffices.
hvanhovell
approved these changes
Apr 7, 2017
Contributor
hvanhovell
left a comment
There was a problem hiding this comment.
LGTM - one minor comment
|
Test build #75606 has finished for PR 17566 at commit
|
|
Test build #75607 has finished for PR 17566 at commit
|
Contributor
|
LGTM - merging to master. Thanks! |
Member
Author
|
Thank you @hvanhovell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add
IGNORE NULLSkeyword infirst/lastin Spark's parser likewise http://docs.oracle.com/cd/B19306_01/server.102/b14200/functions057.htm. This simply maps the keywords to existingignoreNullsExpr.Before
After
How was this patch tested?
Unit tests in
ExpressionParserSuite.