Skip to content

[SPARK-20223][SQL] Fix typo in tpcds q77.sql#17538

Closed
wzhfy wants to merge 1 commit intoapache:masterfrom
wzhfy:typoQ77
Closed

[SPARK-20223][SQL] Fix typo in tpcds q77.sql#17538
wzhfy wants to merge 1 commit intoapache:masterfrom
wzhfy:typoQ77

Conversation

@wzhfy
Copy link
Copy Markdown
Contributor

@wzhfy wzhfy commented Apr 5, 2017

What changes were proposed in this pull request?

Fix typo in tpcds q77.sql

How was this patch tested?

N/A

@srowen
Copy link
Copy Markdown
Member

srowen commented Apr 5, 2017

Looks like a typo, yes, but I wonder how this worked at all? is it not used?

@SparkQA
Copy link
Copy Markdown

SparkQA commented Apr 5, 2017

Test build #75541 has finished for PR 17538 at commit 5fa2ced.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wzhfy
Copy link
Copy Markdown
Contributor Author

wzhfy commented Apr 5, 2017

@srowen There's a benchmark test TPCDSQueryBenchmark that user can run, so I think it should be fixed.

@wzhfy
Copy link
Copy Markdown
Contributor Author

wzhfy commented Apr 5, 2017

retest this please

@srowen
Copy link
Copy Markdown
Member

srowen commented Apr 5, 2017

@wzhfy yeah it's a dumb question maybe, but is that not run automatically and thus why it isn't caught by tests?

@SparkQA
Copy link
Copy Markdown

SparkQA commented Apr 5, 2017

Test build #75546 has finished for PR 17538 at commit 5fa2ced.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Copy Markdown
Member

I think we are not running it in our test case batches. This is for performance evaluation.

Copy link
Copy Markdown
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asfgit pushed a commit that referenced this pull request Apr 5, 2017
## What changes were proposed in this pull request?

Fix typo in tpcds q77.sql

## How was this patch tested?

N/A

Author: wangzhenhua <wangzhenhua@huawei.com>

Closes #17538 from wzhfy/typoQ77.

(cherry picked from commit a2d8d76)
Signed-off-by: Xiao Li <gatorsmile@gmail.com>
asfgit pushed a commit that referenced this pull request Apr 5, 2017
## What changes were proposed in this pull request?

Fix typo in tpcds q77.sql

## How was this patch tested?

N/A

Author: wangzhenhua <wangzhenhua@huawei.com>

Closes #17538 from wzhfy/typoQ77.

(cherry picked from commit a2d8d76)
Signed-off-by: Xiao Li <gatorsmile@gmail.com>
@gatorsmile
Copy link
Copy Markdown
Member

Thanks! Merging to master/2.1/2.0

@asfgit asfgit closed this in a2d8d76 Apr 5, 2017
@wzhfy
Copy link
Copy Markdown
Contributor Author

wzhfy commented Apr 6, 2017

@srowen It's not run automatically. And even if it is run, no error would be caught, the predicate will just become null because casting '2000-08-03]' to Date is failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants