[SPARK-20191][yarn] Crate wrapper for RackResolver so tests can override it.#17508
Closed
vanzin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-20191][yarn] Crate wrapper for RackResolver so tests can override it.#17508vanzin wants to merge 1 commit intoapache:masterfrom
vanzin wants to merge 1 commit intoapache:masterfrom
Conversation
…ide it. Current test code tries to override the RackResolver used by setting configuration params, but because YARN libs statically initialize the resolver the first time it's used, that means that those configs don't really take effect during Spark tests. This change adds a wrapper class that easily allows tests to override the behavior of the resolver for the Spark code that uses it.
|
Test build #75454 has finished for PR 17508 at commit
|
Contributor
Author
srowen
approved these changes
Apr 4, 2017
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems OK as a simple dependency injection mechanism though you all will know this code better than I
Contributor
Author
|
Merging to master / 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Apr 4, 2017
…ide it. Current test code tries to override the RackResolver used by setting configuration params, but because YARN libs statically initialize the resolver the first time it's used, that means that those configs don't really take effect during Spark tests. This change adds a wrapper class that easily allows tests to override the behavior of the resolver for the Spark code that uses it. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes #17508 from vanzin/SPARK-20191. (cherry picked from commit 0736980) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current test code tries to override the RackResolver used by setting
configuration params, but because YARN libs statically initialize the
resolver the first time it's used, that means that those configs don't
really take effect during Spark tests.
This change adds a wrapper class that easily allows tests to override the
behavior of the resolver for the Spark code that uses it.