[SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to simplify driver side metric updates #17464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver side metric updates
ueshin
reviewed
Mar 29, 2017
Member
ueshin
left a comment
ueshin
left a comment
There was a problem hiding this comment.
LGTM except for a minor comment, pending Jenkins.
|
|
||
| SQLMetrics.postDriverMetricUpdates( | ||
| sparkContext, | ||
| sc.getLocalProperty(SQLExecution.EXECUTION_ID_KEY), |
Member
There was a problem hiding this comment.
Should these be used the same variable name, sparkContext or sc?
Contributor
Author
There was a problem hiding this comment.
hm for some reason both works. i agree it'd be better to be the same.
|
Test build #75344 has started for PR 17464 at commit |
|
Test build #75343 has finished for PR 17464 at commit
|
Contributor
Author
|
Merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Mar 29, 2017
…ver side metric updates ## What changes were proposed in this pull request? It is not super intuitive how to update SQLMetric on the driver side. This patch introduces a new SQLMetrics.postDriverMetricUpdates function to do that, and adds documentation to make it more obvious. ## How was this patch tested? Updated a test case to use this method. Author: Reynold Xin <[email protected]> Closes #17464 from rxin/SPARK-20134. (cherry picked from commit 9712bd3) Signed-off-by: Reynold Xin <[email protected]>
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It is not super intuitive how to update SQLMetric on the driver side. This patch introduces a new SQLMetrics.postDriverMetricUpdates function to do that, and adds documentation to make it more obvious.
How was this patch tested?
Updated a test case to use this method.