-
Notifications
You must be signed in to change notification settings - Fork 29k
[DOCS] Clarify round mode for format_number & round functions #17399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
Have a look at http://spark.apache.org/contributing.html as the template says. |
|
Hmm @srowen do you mean describe HALF_EVEN round mode? Also, I know some of the other functions that use this type of rounding already include it in their definition. |
|
No I really meant fill out the PR a little more (see link). The title isn't descriptive. |
|
Thanks for contributing to Spark @roxannemoslehi ! I think Sean just means updating the title to something more like |
|
Yea we definitely need a better title. Thanks for contributing though. |
|
@roxannemoslehi can you fix the title? We can then merge this. |
|
Yup! Sorry about that everyone. Looks like my intended commit message didn't make it through originally but should be fixed now! |
|
How about the doc of the |
|
Looks like round uses |
|
Thanks - merging in master. |
## What changes were proposed in this pull request? This PR proposes to match minor documentations changes in #17399 and #17380 to R/Python. ## How was this patch tested? Manual tests in Python , Python tests via `./python/run-tests.py --module=pyspark-sql` and lint-checks for Python/R. Author: hyukjinkwon <[email protected]> Closes #17429 from HyukjinKwon/minor-match-doc.
What changes were proposed in this pull request?
Updated the description for the
format_numberdescription to indicate that it usesHALF_EVENrounding. Updated the description for therounddescription to indicate that it usesHALF_UProunding.How was this patch tested?
Just changing the two function comments so no testing involved.
Please review http://spark.apache.org/contributing.html before opening a pull request.