Skip to content

[SPARK-20021][PySpark] Miss backslash in python code #17352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
uncleGen wants to merge 3 commits into from
Closed

[SPARK-20021][PySpark] Miss backslash in python code #17352

uncleGen wants to merge 3 commits into from

Conversation

@uncleGen
Copy link
Contributor

@uncleGen uncleGen commented Mar 20, 2017 •
edited
Loading

What changes were proposed in this pull request?

Add backslash for line continuation in python code.

How was this patch tested?

Jenkins.

@uncleGen uncleGen changed the title Miss backslash in python code [SPARK-20021][PySpark] Miss backslash in python code Mar 20, 2017
@SparkQA
Copy link

SparkQA commented Mar 20, 2017

Test build #74839 has finished for PR 17352 at commit 965dce3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@uncleGen
Copy link
Contributor Author

uncleGen commented Mar 20, 2017 •
edited
Loading

cc @felixcheung and @srowen

felixcheung
felixcheung approved these changes Mar 20, 2017
View reviewed changes
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Mar 20, 2017

LGTM too.

@holdenk
Copy link
Contributor

holdenk commented Mar 21, 2017

This looks reasonable, however there is a conflict, can you update this to the latest master?

@SparkQA
Copy link

SparkQA commented Mar 21, 2017

Test build #74923 has finished for PR 17352 at commit 1dfd3ee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class JsonToStructs(
  • case class StructsToJson(
  • case class StarSchemaDetection(conf: SQLConf) extends PredicateHelper
  • * Helper case class to hold (plan, rowCount) pairs.
  • case class ReorderJoin(conf: SQLConf) extends Rule[LogicalPlan] with PredicateHelper

asfgit pushed a commit that referenced this pull request Mar 22, 2017
@uncleGen @srowen
[SPARK-20021][PYSPARK] Miss backslash in python code
56f997f 
## What changes were proposed in this pull request?

Add backslash for line continuation in python code.

## How was this patch tested?

Jenkins.

Author: uncleGen <[email protected]>
Author: dylon <[email protected]>

Closes #17352 from uncleGen/python-example-doc.

(cherry picked from commit facfd60)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented Mar 22, 2017

Merged to master / 2.1

@asfgit asfgit closed this in facfd60 Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@felixcheung felixcheung felixcheung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uncleGen @SparkQA @HyukjinKwon @holdenk @srowen @felixcheung