Skip to content

[SPARK-19970][SQL] Table owner should be USER instead of PRINCIPAL in kerberized clusters #17311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 5 commits into from
Closed

[SPARK-19970][SQL] Table owner should be USER instead of PRINCIPAL in kerberized clusters #17311

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dfbf82
[SPARK-19970][SQL] Table owner should be USER instead of PRINCIPAL in…
dongjoon-hyun Mar 16, 2017
e8ef7d1
Replace `getUserFromAuthenticator` because it is introduced in 0.13.
dongjoon-hyun Mar 16, 2017
2959d98
Change styles.
dongjoon-hyun Mar 17, 2017
5efdf8b
`conf` is not used.
dongjoon-hyun Mar 17, 2017
258ff8d
Revert "`conf` is not used."
dongjoon-hyun Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {
hiveTable.setFields(schema.asJava)
}
hiveTable.setPartCols(partCols.asJava)
conf.foreach(c => hiveTable.setOwner(c.getUser))
conf.foreach(c => hiveTable.setOwner(SessionState.get().getAuthenticator().getUserName()))

@dongjoon-hyun dongjoon-hyun Mar 17, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use the following since it was introduced in 0.13.

conf.foreach(c => hiveTable.setOwner(SessionState.getUserFromAuthenticator()))

@vanzin vanzin Mar 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're touching this, could you make it follow the usual style?

.foreach { c => ... }

@dongjoon-hyun dongjoon-hyun Mar 17, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review, @vanzin !
Which object do you mean for .foreach here?
For conf, we already use that.
For SessionState.get(), it's not Option.

@vanzin vanzin Mar 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one foreach call and it's using a different style than the rest of the code.

@dongjoon-hyun dongjoon-hyun Mar 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. It's about removing .foreach.

@vanzin vanzin Mar 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's about style. Parentheses v. braces.

@dongjoon-hyun dongjoon-hyun Mar 17, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Sorry again.

hiveTable.setCreateTime((table.createTime / 1000).toInt)
hiveTable.setLastAccessTime((table.lastAccessTime / 1000).toInt)
table.storage.locationUri.map(CatalogUtils.URIToString(_)).foreach { loc =>
Expand Down