-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-19830] [SQL] Add parseTableSchema API to ParserInterface #17171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ package org.apache.spark.sql.catalyst.parser | |
| import org.apache.spark.sql.catalyst.TableIdentifier | ||
| import org.apache.spark.sql.catalyst.expressions.Expression | ||
| import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan | ||
| import org.apache.spark.sql.types.StructType | ||
|
|
||
| /** | ||
| * Interface for a parser. | ||
|
|
@@ -33,4 +34,7 @@ trait ParserInterface { | |
|
|
||
| /** Creates TableIdentifier for a given SQL string. */ | ||
| def parseTableIdentifier(sqlText: String): TableIdentifier | ||
|
|
||
| /** Creates StructType for a given SQL string. */ | ||
| def parseTableSchema(sqlText: String): StructType | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So the difference between the |
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.catalyst.parser | ||
|
|
||
| import org.apache.spark.SparkFunSuite | ||
| import org.apache.spark.sql.types._ | ||
|
|
||
| class TableSchemaParserSuite extends SparkFunSuite { | ||
|
|
||
| def parse(sql: String): DataType = CatalystSqlParser.parseTableSchema(sql) | ||
|
|
||
| def checkTableSchema(tableSchemaString: String, expectedDataType: DataType): Unit = { | ||
| test(s"parse ${tableSchemaString.replace("\n", "")}") { | ||
|
||
| assert(parse(tableSchemaString) === expectedDataType) | ||
| } | ||
| } | ||
|
|
||
| checkTableSchema("a int", (new StructType).add("a", "int")) | ||
|
||
| checkTableSchema("A int", (new StructType).add("A", "int")) | ||
| checkTableSchema("a INT", (new StructType).add("a", "int")) | ||
| checkTableSchema("`!@#$%.^&*()` string", (new StructType).add("!@#$%.^&*()", "string")) | ||
| checkTableSchema("a int, b long", (new StructType).add("a", "int").add("b", "long")) | ||
| checkTableSchema("a STRUCT<intType: int, ts:timestamp>", | ||
| StructType( | ||
| StructField("a", StructType( | ||
| StructField("intType", IntegerType) :: | ||
| StructField("ts", TimestampType) :: Nil)) :: Nil)) | ||
|
|
||
| checkTableSchema( | ||
| "a int comment 'test'", | ||
| (new StructType).add("a", "int", nullable = true, "test")) | ||
|
|
||
| test("complex hive type") { | ||
| val tableSchemaString = | ||
| """ | ||
| |complexStructCol struct< | ||
| |struct:struct<deciMal:DECimal, anotherDecimal:decimAL(5,2)>, | ||
| |MAP:Map<timestamp, varchar(10)>, | ||
| |arrAy:Array<double>, | ||
| |anotherArray:Array<char(9)>> | ||
| """.stripMargin.replace("\n", "") | ||
|
|
||
| val builder = new MetadataBuilder | ||
| builder.putString(HIVE_TYPE_STRING, | ||
| "struct<struct:struct<deciMal:decimal(10,0),anotherDecimal:decimal(5,2)>," + | ||
| "MAP:map<timestamp,varchar(10)>,arrAy:array<double>,anotherArray:array<char(9)>>") | ||
|
|
||
| val expectedDataType = | ||
| StructType( | ||
| StructField("complexStructCol", StructType( | ||
| StructField("struct", | ||
| StructType( | ||
| StructField("deciMal", DecimalType.USER_DEFAULT) :: | ||
| StructField("anotherDecimal", DecimalType(5, 2)) :: Nil)) :: | ||
| StructField("MAP", MapType(TimestampType, StringType)) :: | ||
| StructField("arrAy", ArrayType(DoubleType)) :: | ||
| StructField("anotherArray", ArrayType(StringType)) :: Nil), | ||
| nullable = true, | ||
| builder.build()) :: Nil) | ||
|
|
||
| assert(parse(tableSchemaString) === expectedDataType) | ||
| } | ||
|
|
||
| test("illegal col types") { | ||
| val e = intercept[ParseException] { | ||
| CatalystSqlParser.parseTableSchema("a INT b long") | ||
| }.getMessage | ||
| assert(e.contains("mismatched input 'b' expecting {<EOF>, '(', ',', 'COMMENT'}")) | ||
|
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be a little bit careful here. I think we may need to add a rule similar to
singleDataTypeto the grammar and expose its implementation. This to prevent us from silently dropping trailing input, or having a weird error on trailing input; it seems we get a somewhat vague error ATM...