[SPARK-19787][ML] Changing the default parameter of regParam. #17121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Mar 1, 2017
Contributor
|
ok to test |
Contributor
|
I'm not sure if this will break MiMa - let's see |
|
Test build #3587 has finished for PR 17121 at commit
|
Contributor
|
@datumbox LGTM, thanks. Merged to master. By the way - this is a tiny change and sometimes we don't bother, and if we do it it can have a [MINOR] tag in the PR title. Having said that there's been many cases before where supposedly minor changes break things inadvertently and then it's more difficult to track as there is no JIRA etc. I tend to err on the side of caution :) |
Contributor
Author
|
@MLnick Sounds good to me thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the ALS method the default values of regParam do not match within the same file (lines 224 and 714). In one place we set it to 1.0 and in the other to 0.1.
I changed the one of train() method to 0.1 and now it matches the default value which is visible to Spark users. The method is marked with DeveloperApi so it should not affect the users. Whenever we use the particular method we provide all parameters, so the default does not matter. Only exception is the unit-tests on ALSSuite but the change does not break them.
Note: This PR should get the award of the laziest commit in Spark history. Originally I wanted to correct this on another PR but @MLnick suggested to create a separate PR & ticket. If you think this change is too insignificant/minor, you are probably right, so feel free to reject and close this. :)
How was this patch tested?
Unit-tests