[SPARK-19774] StreamExecution should call stop() on sources when a stream fails #17107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
zsxwing
reviewed
Feb 28, 2017
| final val fakeSchema = StructType(StructField("a", IntegerType) :: Nil) | ||
|
|
||
| def withMockSources(sources: Source*)(f: => Unit): Unit = { | ||
| require(sources.nonEmpty) |
Member
There was a problem hiding this comment.
nit: You can use withMockSources(firstSource: Source, otherSources: Source*) to make it become a compile error.
| def withMockSources(sources: Source*)(f: => Unit): Unit = { | ||
| require(sources.nonEmpty) | ||
| var i = 0 | ||
| val srcProvider = () => { |
Member
There was a problem hiding this comment.
nit: srcProvider is not necessary. You can just assign the func to sourceProviderFunction
Contributor
Author
|
@zsxwing Addressed |
|
Test build #73617 has finished for PR 17107 at commit
|
|
Test build #73619 has finished for PR 17107 at commit
|
Member
|
Thanks. LGTM. Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Mar 3, 2017
…ream fails ## What changes were proposed in this pull request? We call stop() on a Structured Streaming Source only when the stream is shutdown when a user calls streamingQuery.stop(). We should actually stop all sources when the stream fails as well, otherwise we may leak resources, e.g. connections to Kafka. ## How was this patch tested? Unit tests in `StreamingQuerySuite`. Author: Burak Yavuz <[email protected]> Closes #17107 from brkyvz/close-source. (cherry picked from commit 9314c08) Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We call stop() on a Structured Streaming Source only when the stream is shutdown when a user calls streamingQuery.stop(). We should actually stop all sources when the stream fails as well, otherwise we may leak resources, e.g. connections to Kafka.
How was this patch tested?
Unit tests in
StreamingQuerySuite.