-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-19345][ML][DOC] Add doc for "coldStartStrategy" usage in ALS #17102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #73599 has finished for PR 17102 at commit
|
holdenk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python side looks good :)
sethah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple really small things. Otherwise the changes look good. I didn't build the docs or run the examples.
docs/ml-collaborative-filtering.md
Outdated
| The evaluation metric will then be computed over the non-`NaN` data and will be valid. | ||
| Usage of this parameter is illustrated in the example below. | ||
|
|
||
| **Note:** currently the supported cold start strategies are `nan` (the default behavior mentioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit wary of putting the options explicitly here, but it seems hard to avoid since they're mentioned above. Even so, maybe use "drop" and "nan" (quotes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah here I wanted to explicitly mention the "drop" option. Ideally will remove this note section when further strategies are added (like the average user vector idea).
docs/ml-collaborative-filtering.md
Outdated
| scenarios: | ||
|
|
||
| 1. In production, for new users or items that have no rating history and on which the model has not | ||
| been trained (this is the "cold start problem") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add punctuation (other places in the user guide have punctuation despite the fact that we are listing things)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing
|
Test build #73703 has finished for PR 17102 at commit
|
|
Merged to master |
SPARK-14489 added the ability to skip
NaNpredictions duringALSModel.transform. This PR adds documentation for thecoldStartStrategyparam to the ALS user guide, and add code to the examples to illustrate usage.How was this patch tested?
Doc and example change only. Build HTML doc locally and verified example code builds, and runs in shell for Scala/Python.