[SPARK-19756][SQL] drop the table cache after inserting into a data source table#17089
Closed
cloud-fan wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-19756][SQL] drop the table cache after inserting into a data source table#17089cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @gatorsmile |
|
Test build #73541 has started for PR 17089 at commit |
windpiger
reviewed
Feb 28, 2017
|
|
||
| fileIndex.foreach(_.refresh()) | ||
| catalogTable.foreach { table => | ||
| sparkSession.sharedState.cacheManager.uncacheQuery(sparkSession.table(table.identifier)) |
Contributor
There was a problem hiding this comment.
uncache it or refresh it use refreshByPath?
In this PR
Member
There was a problem hiding this comment.
This PR can make the behavior consistent with what we did for insertion of Hive serve tables
Contributor
There was a problem hiding this comment.
it is recached? maybe we can use invalidateCachedPath https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala#L154
Member
|
retest this please |
|
Test build #73564 has finished for PR 17089 at commit
|
Contributor
Author
|
closing in favor of #16809 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When we inserting into a table, we should uncache it to avoid exposing stale data. This is the existing behavior for hive tables, see
InsertIntoHiveTable, this PR fixes this problem for data source tables.How was this patch tested?
new regression test