[SPARK-19718][SS]Handle more interrupt cases properly for Hadoop #17044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
commented
Feb 23, 2017
|
|
||
| /** States for [[StreamExecution]]'s lifecycle. */ | ||
| trait State | ||
| case object INITIALIZING extends State |
Member
Author
There was a problem hiding this comment.
move them out to avoid holding the StreamExecution lock when initializing them.
Contributor
There was a problem hiding this comment.
Makes sense. I'd consider putting this stuff at the top if not in its own file. Otherwise its kind of an awkward forward reference.
|
Test build #73369 has finished for PR 17044 at commit
|
Contributor
|
@zsxwing I'm not the right person to review this, but can we get the ball rolling on this fix? This test is really flaky and constantly causes PR builders to fail. |
Member
Author
|
@tdas could you take a look? |
Contributor
|
LGTM |
|
Test build #73869 has finished for PR 17044 at commit
|
Member
Author
|
Thanks. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-19617 changed
HDFSMetadataLogto enable interrupts when using the local file system. However, now we hit HADOOP-12074:Shell.runCommandconvertsInterruptedExceptiontonew IOException(ie.toString())before Hadoop 2.8. This is the Hadoop patch to fix HADOOP-1207: apache/hadoop@95c73d4This PR adds new logic to handle the following cases related to
InterruptedException.java.lang.InterruptedException. If so, treat it asInterruptedException. This is for pre-Hadoop 2.8.InterruptedIOExceptionasInterruptedException. This is for Hadoop 2.8+ and other places that may throwInterruptedIOExceptionwhen the thread is interrupted.How was this patch tested?
The new unit test.